Skip to content

fix for gradle tools 9#420

Merged
hansemannn merged 9 commits into
masterfrom
gradle9Fixes
Jun 28, 2026
Merged

fix for gradle tools 9#420
hansemannn merged 9 commits into
masterfrom
gradle9Fixes

Conversation

@m1ga

@m1ga m1ga commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixing gradle issues, needed for tidev/titanium-sdk#14410

  • fix gradle 9 parts (e.g. load external libraries)
  • upgrade commons-lang3
  • upgrade npm packages

@m1ga m1ga mentioned this pull request Mar 31, 2026
Merged
@m1ga m1ga marked this pull request as draft May 19, 2026 11:45
@socket-security

socket-security Bot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedtitanium@​5.4.1 ⏵ 8.1.579 +2100100 +195 +6100

View full report

@m1ga m1ga marked this pull request as ready for review May 19, 2026 12:34
@m1ga

m1ga commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@hansemannn since the gradle 9 update was merged into 13.3.0 we have to merge this one here too (was linked in the other PR). Otherwise building hyperloop apps will show:

[ERROR] [GRADLE] 
[ERROR] [GRADLE] FAILURE: Build failed with an exception.
[ERROR] [GRADLE] 
[ERROR] [GRADLE] * Where:
[ERROR] [GRADLE] Build file '/home/miga/tools/hyperloop-examples/build/hyperloop/android/gradle-project/build.gradle' line: 56
[ERROR] [GRADLE] 
[ERROR] [GRADLE] * What went wrong:
[ERROR] [GRADLE] Execution failed for task ':gradle-project:generateJarDependenciesFile'.
[ERROR] [GRADLE] > Could not get unknown property 'sdkDirectory' for object of type com.android.build.gradle.internal.dsl.LibraryExtensionImpl$AgpDecorated.
[ERROR] [GRADLE] 
[ERROR] [GRADLE] * Try:
[ERROR] [GRADLE] > Run with --stacktrace option to get the stack trace.
[ERROR] [GRADLE] > Run with --info or --debug option to get more log output.
[ERROR] [GRADLE] > Run with --scan to get full insights from a Build Scan (powered by Develocity).
[ERROR] [GRADLE] > Get more help at https://help.gradle.org.
[ERROR] [GRADLE] 
[ERROR] [GRADLE] BUILD FAILED in 9s
[ERROR] "gradlew" tool returned exit code: 1

Test module: hyperloop-android-8.0.0.zip

@m1ga m1ga requested a review from hansemannn June 17, 2026 15:19
hansemannn
hansemannn requested changes Jun 18, 2026
View reviewed changes
Comment thread .github/workflows/android.yml Outdated
Comment thread .github/workflows/ios.yml Outdated
Comment thread .github/workflows/ios.yml
Comment thread android/hooks/build.gradle.ejs
@socket-security

socket-security Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm execa is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: package-lock.json → npm/titanium@8.1.5 → npm/execa@9.6.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/execa@9.6.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@hansemannn hansemannn merged commit 52ca27c into master Jun 28, 2026
7 checks passed
@hansemannn hansemannn deleted the gradle9Fixes branch June 28, 2026 12:01
@hansemannn

hansemannn commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

@m1ga Can you release the new builds?

@m1ga

m1ga commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

I'll have a look in a bit but I think I can do that.

@m1ga

m1ga commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

@hansemannn hold on, I can't build the iOS version at the moment (don't have my Mac with me) so I can't run the build.sh script. If you can do that feel free. Otherwise I'll try it in the evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m1ga @hansemannn